[9] RFR: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B API, JAX-WS API, SAAJ-API

huizhe wang huizhe.wang at oracle.com
Wed Jul 8 16:56:00 UTC 2015


--- 
old/src/java.annotations.common/share/classes/javax/annotation/PostConstruct.java 
2015-07-08 13:25:02.000000000 +0200
+++ 
new/src/java.annotations.common/share/classes/javax/annotation/PostConstruct.java 
2015-07-08 13:25:01.000000000 +0200
- * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights 
reserved.

Did you mean "2015"?  Also in PreDestroy.java.

--- old/src/java.xml.bind/share/classes/javax/xml/bind/JAXBContext.java 
2015-07-08 13:25:03.000000000 +0200
+++ new/src/java.xml.bind/share/classes/javax/xml/bind/JAXBContext.java 
2015-07-08 13:25:03.000000000 +0200

Many replacement of @code with <tt>, is that intended? (maybe 
accidentally reversed to old format?)  @code is better than <tt>.  
Although it will work, tt is not recommended at W3C 
<http://www.w3.org/wiki/HTML/Elements/tt>.

--- old/src/java.xml.ws/share/classes/javax/xml/soap/SOAPConnection.java 
2015-07-08 13:25:10.000000000 +0200
+++ new/src/java.xml.ws/share/classes/javax/xml/soap/SOAPConnection.java 
2015-07-08 13:25:10.000000000 +0200
- * <PRE>
+ * {@code
   *      SOAPConnectionFactory factory = 
SOAPConnectionFactory.newInstance();
   *      SOAPConnection con = factory.createConnection();
- * </PRE>
- * A <code>SOAPConnection</code> object can be used to send messages
+ * }

@code does not handle linebreaks unfortunately, you still need <pre> 
outside of @code.

-Joe

On 7/8/2015 5:29 AM, Miroslav Kos wrote:
> Hi everybody,
> I'd like to ask for review for following issue:
>
> JBS: 8130753: Sync-up javadoc changes in jax-ws area - includes JAX-B 
> API, JAX-WS API, SAAJ-API
> webrev: http://cr.openjdk.java.net/~mkos/8130753/jaxws.01/
>
> It addresses all the javadoc errors in all 3 JSRs: SAAJ, JAX-B and 
> JAX-WS and it is also syncup with standalone repos. This clean-up had 
> to be done in order to proceed with changes necessary for Jigsaw 
> (specifically SAAJ API and possibly JAX-WS).
>
> Thanks
> Miran
>
>




More information about the core-libs-dev mailing list