RFR: 6260652: (coll) Arrays.asList(x).toArray().getClass() should be Object[].class

Paul Sandoz paul.sandoz at oracle.com
Thu Jul 9 07:28:55 UTC 2015


On Jul 8, 2015, at 8:55 PM, Martin Buchholz <martinrb at google.com> wrote:

> 
> 
> On Wed, Jul 8, 2015 at 12:59 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:
> 
> > The comment remains correct even if 6260652 is fixed.
> > I can't think up a clearly better one.
> 
> I would recommend at least removing the issue id (since that refers specifically to Arrays.asList rather than something general that cannot actually be fixed). Up to you.
> 
> I improved (?) various comments referring to  6260652
> 
> -        // c.toArray might (incorrectly) not return Object[] (see 6260652)
> +        // defend against c.toArray (incorrectly) not returning Object[]
> +        // (see e.g. https://bugs.openjdk.java.net/browse/JDK-6260652)
> 

I think that is improved, linking is also helpful.

+1

Paul.

> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Arrays.asList.toArray/




More information about the core-libs-dev mailing list