RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

[huizhe wang]

On 7/28/2015 10:32 AM, Daniel Fuchs wrote:
> On 28/07/15 19:20, huizhe wang wrote:
>> Hi Daniel,
>>
>>
>> On 7/28/2015 8:22 AM, Daniel Fuchs wrote:
>>> Hi,
>>>
>>> Please find below a fix for yet another cleanup for jaxp:
>>
>> Thanks for yet another cleanup! And, there is a lot more to come :-)
>>>
>>> 8130059: jaxp: Investigate removal of
>>> com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java
>>> https://bugs.openjdk.java.net/browse/JDK-8130059
>>>
>>> http://cr.openjdk.java.net/~dfuchs/webrev_8130059/webrev.00/
>>>
>>> EnvironmentCheck doesn't seem to serve any purpose in JDK 9.
>>
>> Agree. It'd be a confusion more than anything else if used since it
>> produces many irrelevant information.
>>
>>> It is not called anywhere. The proposal is to remove it.
>>> By doing a full grep on the JDK I also identified another
>>> unused class (Hashtree2Node.java) which referred to EnvironmentCheck
>>> inside a comment.
>>> I took the liberty to remove that class as well.
>>
>> Ok.  The webrev looks good to me. If you'd want to remove the two
>> Version classes as shown in the test, that would be fine with me too.
>> Then you could remove the whole test.
>
> Thanks Joe!
>
> One of the two version classes (xalan) is used by ...xslt.Process.java
> I already logged another bug to investigate removing that as
> well (JDK-8130058).

Great!
>
> Maybe we should remove the two versions classes as part of that
> other bug? Or I could update my webrev to just remove the xerces
> Version.java now, which as far as I can see is not called anywhere.
>
> As you prefer :-)

I agree as you planned, considering removing the two version classes in 
JDK-8130058.

Cheers :-)

Joe

>
> cheers,
>
> -- daniel
>
>>
>> Best regards,
>> Joe
>>
>>>
>>> As for the latter cleanup, what triggered this is that EnvironmentCheck
>>> is using sun.boot.class.path...
>>>
>>> best regards,
>>>
>>> -- daniel
>>
>