RFR(S): 8132704: [TESTBUG] jdk/internal/jimage/ExecutableTest.java incorrectly asserts all files to be executable

Roger Riggs Roger.Riggs at Oracle.com
Thu Jul 30 15:34:06 UTC 2015


Hi Volker,

Possibly the real bug is that there is non-executable file in the bin 
directory.
There is a /conf directory which would probably be a better place for that.

Roger





On 7/30/2015 11:28 AM, Volker Simonis wrote:
> Hi,
>
> can somebody please review this test fix:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2015/8132704/
> https://bugs.openjdk.java.net/browse/JDK-8132704
>
> The initial test checked that all the files in the bin/ directory are
> executable by everybody. Unfortunately this was too optimistic because
> in the closed build the bin/ directory contains configuration files
> which are not executable.
>
> The new version of the test uses a predefined static list of
> executables which are checked for the executable permissions if the
> corresponding files exist.
>
> Thank you and best regards,
> Volker




More information about the core-libs-dev mailing list