RFR 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Paul Sandoz
paul.sandoz at oracle.com
Fri Jul 31 07:49:03 UTC 2015
On 31 Jul 2015, at 01:32, Stuart Marks <stuart.marks at oracle.com> wrote:
> Hi Paul,
>
> Changes look good.
Thanks.
> (The webrev changesets are a bit odd, though; are you running webrev on a branchy repo or something?)
>
No, nothing special, but something has changed that is making the webrev script behave differently.
Paul.
> Stefan, Tagir, thanks for spotting these issues.
>
> s'marks
>
> On 7/30/15 9:32 AM, Paul Sandoz wrote:
>> Hi Stefan, Tagir,
>>
>> Updated:
>>
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8130828-stream-doc-typos/webrev/
>>
>> Paul.
>>
>> On 30 Jul 2015, at 18:08, Stefan Zobel <spliterator at gmail.com> wrote:
>>
>>> Hi Paul,
>>>
>>> perhaps you could take the opportunity and also add the missing "@since
>>> 1.9" tags to all the new dropWhile() / takeWhile() methods (JDK-8071597).
>>>
>>> Also in dropWhile() / takeWhile() there is a small typo (I guess) in the
>>> Javadoc:
>>>
>>>
>>> takeWhile: "takes all elements (the result is the same is the input)"
>>>
>>> dropWhile: "the stream match the given predicate then no elements are
>>> dropped (the result is the same is the input)"
>>>
>>>
>>> I guess that should read: "(the result is the same as is the input)"?
>>>
>>>
>>> Stefan
>>
More information about the core-libs-dev
mailing list