RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

Aleksej Efimov aleksej.efimov at oracle.com
Thu Jun 25 17:52:49 UTC 2015


Hi Ivan!
Thanks for suggestions. Also I took an opportunity and rewrote it to 
testNG format + cleaned it up and modified schema content check logic. 
Now test looks more readable: 
http://cr.openjdk.java.net/~aefimov/8076139/9/01

With Best Regards,
Aleksej

On 06/25/2015 05:54 PM, Ivan Gerasimov wrote:
> Hi Aleksej!
>
> Would it make sense to use jdk.testlibrary.JDKToolLauncher to run 
> schemagen?
> This way the test would become somewhat shorter.
>
> Sincerely yours,
> Ivan
>
> On 25.06.2015 17:31, Aleksej Efimov wrote:
>> Hi,
>> Any comments on this changes?
>>
>> With Best Regards,
>> Aleksej
>>
>> On 06/23/2015 07:02 PM, Aleksej Efimov wrote:
>>> Hi,
>>>
>>> Please, review, comment and approve GenerateEnumSchema.java test bug 
>>> fix [1]. It solves the following problem: test launches schemagen 
>>> tool from a 'test.src' folder and in cases when 'test.src' is not 
>>> writeable failure occurs. The proposed fix [2] solves this issue - 
>>> it creates a test folder in a scratch (or in current) directory and 
>>> also populates directories for each schemagen run (output for each 
>>> run is saved for analysis). Modified test was executed via JPRT and 
>>> JTREG. In case of JTREG it was executed over read-only 'test.src' 
>>> directory too. No test failure were observed.
>>> Also, the test was moved to proper directory 
>>> (test/javax/xml/bind/jxc/8046817) to match it's nature and 
>>> functionality.
>>>
>>> With Best Regards,
>>> Aleksej
>>>
>>> [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8076139
>>> [2] Webrev: http://cr.openjdk.java.net/~aefimov/8076139/9/00
>>
>>
>>
>




More information about the core-libs-dev mailing list