RFR: 8076139: [TEST_BUG] test/javax/xml/ws/8046817/GenerateEnumSchema.java creates files in test.src

[Ivan Gerasimov]

Thanks Aleksej, the test looks much more laconic now.

A few minor comments.
- in the regexps the very last quantifier should better be greedy: ".+" 
instead of ".+?", since you want the whole string to be eaten up to the 
end anyway.
- 72     public void SchemangenGenerationTestCase()  --- it's a bit 
unusual to see the method name started with a capital letter.
- 73         String regexp ) --- extra space.
- 80         runSchemaGen(inputFileName,testCaseDir); --- missing space.
- 99             logOutput(p);  --- wouldn't it be the same effect, if 
you set pb.inheritIO()?

Otherwise looks good.

Sincerely yours,
Ivan


On 25.06.2015 20:52, Aleksej Efimov wrote:
> Hi Ivan!
> Thanks for suggestions. Also I took an opportunity and rewrote it to 
> testNG format + cleaned it up and modified schema content check logic. 
> Now test looks more readable: 
> http://cr.openjdk.java.net/~aefimov/8076139/9/01
>
> With Best Regards,
> Aleksej
>
> On 06/25/2015 05:54 PM, Ivan Gerasimov wrote:
>> Hi Aleksej!
>>
>> Would it make sense to use jdk.testlibrary.JDKToolLauncher to run 
>> schemagen?
>> This way the test would become somewhat shorter.
>>
>> Sincerely yours,
>> Ivan
>>
>> On 25.06.2015 17:31, Aleksej Efimov wrote:
>>> Hi,
>>> Any comments on this changes?
>>>
>>> With Best Regards,
>>> Aleksej
>>>
>>> On 06/23/2015 07:02 PM, Aleksej Efimov wrote:
>>>> Hi,
>>>>
>>>> Please, review, comment and approve GenerateEnumSchema.java test 
>>>> bug fix [1]. It solves the following problem: test launches 
>>>> schemagen tool from a 'test.src' folder and in cases when 
>>>> 'test.src' is not writeable failure occurs. The proposed fix [2] 
>>>> solves this issue - it creates a test folder in a scratch (or in 
>>>> current) directory and also populates directories for each 
>>>> schemagen run (output for each run is saved for analysis). Modified 
>>>> test was executed via JPRT and JTREG. In case of JTREG it was 
>>>> executed over read-only 'test.src' directory too. No test failure 
>>>> were observed.
>>>> Also, the test was moved to proper directory 
>>>> (test/javax/xml/bind/jxc/8046817) to match it's nature and 
>>>> functionality.
>>>>
>>>> With Best Regards,
>>>> Aleksej
>>>>
>>>> [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8076139
>>>> [2] Webrev: http://cr.openjdk.java.net/~aefimov/8076139/9/00
>>>
>>>
>>>
>>
>
>
>