RFR 8068260: java/io/Serializable/clearHandleTable/ClearHandleTable.java timed out

[Chris Hegarty]

On 04/03/15 15:58, Roger Riggs wrote:
> Hi Chris,
>
> ok, though if System.gc is good enough it would not need a loop and
> timeout logic.

Ah ok, so some common library function taking a Predicate, or similar. I 
got you now.

> It would be interesting to know if it ever needs to go through the loop
> more than once.

In my testing it only ever goes through once.

> Maybe some indication of that can be added to the test output.

I added some output ( updated the webrev in-place). The test should be 
quiet unless there is a problem.

-Chris.

>
> Thanks, Roger
>
>
> On 3/4/2015 10:57 AM, Chris Hegarty wrote:
>> On 04/03/15 15:17, Roger Riggs wrote:
>>> Hi Chris,
>>>
>>> looks fine.
>>
>> Thanks Roger.
>>
>>> Do you suppose the test library should have a function that takes a set
>>> of (Weak)Refs
>>> and does whatever it takes to clear them (or timeout).
>>
>> Well, the problem is: What is "whatever it takes"? The changes in this
>> test are only "less bad", and typically take less time to execute. I'd
>> like to keep an eye on the test after this change is pushed to see if
>> there are any future issues with it.
>>
>>> Perhaps even a public API in Runtime...
>>
>> I think, System.gc is good enough, but maybe there is scope for
>> something else here.
>>
>> -Chris.
>>
>>> Roger
>>>
>>> On 3/4/2015 9:59 AM, Chris Hegarty wrote:
>>>> This is a small, test only, review request to fix an intermittently
>>>> failing test.
>>>>
>>>> It replaces a "bad" technique, heap exhaustion, with the "less bad"
>>>> technique of calling System.gc, potentially multiple times, to clear
>>>> weak references. With this change the test runs much quicker, and has
>>>> not failed in several thousands of runs on a local machine.
>>>>
>>>> http://cr.openjdk.java.net/~chegar/8068260/webrev.00/webrev/
>>>>
>>>> -Chris.
>>>
>