RFR (JAXP): 8049378: Examine references to ${java.home}/lib in JAXP

[Lance Andersen]

Hi Joe,

A couple other very minor suggestions  to consider assuming -Xdoclint is clean:

-  Your new changes just use  <P> where the older code used <P></P>.   It would be nice if we can to be consistent if you have the time.  I think a while a go it was decide that <P> was the way to go.
- In some cases you start a comment off with <p> and others it is on a line of its own. When/if you go back to these files, it might be nice to be consistent (again minor issue). See XMLInputFactory as an example
- Perhaps consider @code{SchemaFactory} vs <code>SchemaFactory</code> (I think this is what Alan was suggesting below as it is in multiple files)

As long as -Xdoclint is clean, you could put this on your todo list for a rainy day and ignore for now :-)

Best
Lance

On Mar 4, 2015, at 4:15 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 04/03/2015 19:50, huizhe wang wrote:
>> Hi,
>> 
>> This is the additional specification change after the move from lib to conf in the jigsaw/m2 forest. Besides the change from lib to conf, the new specification also made the reference to the location non-normative.
>> 
>> Please review:
>> http://cr.openjdk.java.net/~joehw/jdk9/8049378/webrev/
>> 
>> Bug (please login):
>> https://bugs.openjdk.java.net/browse/JDK-8049378
> This looks okay, a small suggestion is to use {@code conf}.
> 
> The additional of the <p> tags caused me to re-read the paraph "Use the srevice-provider ..." where "facility" might be more better than "facilities".
> 
> -Alan



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com