RFR (JAXP): 8049378: Examine references to ${java.home}/lib in JAXP

[huizhe wang]

On 3/4/2015 1:46 PM, Lance Andersen wrote:
> Hi Joe,
>
> A couple other very minor suggestions  to consider assuming -Xdoclint 
> is clean:
>
> -  Your new changes just use  <P> where the older code used <P></P>.   
> It would be nice if we can to be consistent if you have the time.  I 
> think a while a go it was decide that <P> was the way to go.

Yes, <p> is the way to go.

> - In some cases you start a comment off with <p> and others it is on a 
> line of its own. When/if you go back to these files, it might be nice 
> to be consistent (again minor issue). See XMLInputFactory as an example

True. I kind of dropped a <p> there when there's already an empty line.

> - Perhaps consider @code{SchemaFactory} vs <code>SchemaFactory</code> 
> (I think this is what Alan was suggesting below as it is in multiple 
> files)

Sure.
>
> As long as -Xdoclint is clean, you could put this on your todo list 
> for a rainy day and ignore for now :-)

Later, in the bug-fix stage, I'll see if I can get them fixed along with 
lints. For now, I did a few 'replace-all' without manually editing the 
other inconsistent format (so you'll see some lines with{@code xxx}where 
</p> was not removed. Pls forgive me for not being complete. It's 
painful to think that I should have spent the time on the other thing, 
but I thought this was needed so that Deva could get started on StAX.

Thanks,
Joe

>
> Best
> Lance
>
> On Mar 4, 2015, at 4:15 PM, Alan Bateman <Alan.Bateman at oracle.com 
> <mailto:Alan.Bateman at oracle.com>> wrote:
>
>> On 04/03/2015 19:50, huizhe wang wrote:
>>> Hi,
>>>
>>> This is the additional specification change after the move from lib 
>>> to conf in the jigsaw/m2 forest. Besides the change from lib to 
>>> conf, the new specification also made the reference to the location 
>>> non-normative.
>>>
>>> Please review:
>>> http://cr.openjdk.java.net/~joehw/jdk9/8049378/webrev/ 
>>> <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8049378/webrev/>
>>>
>>> Bug (please login):
>>> https://bugs.openjdk.java.net/browse/JDK-8049378
>> This looks okay, a small suggestion is to use {@code conf}.
>>
>> The additional of the <p> tags caused me to re-read the paraph "Use 
>> the srevice-provider ..." where "facility" might be more better than 
>> "facilities".
>>
>> -Alan
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>