String.contains(CharSequence) calls toString on argument

[Xueming Shen]

On 03/20/2015 02:34 AM, Tomasz Kowalczewski wrote:
> Hello!
>
> Current implementation of String.contains that accepts CharSequence calls
> toString on it and passes resulting string to indexOf(String). This IMO
> defeats the purpose of using CharSequences (that is to have a mutable
> character buffer and not allocate unnecessary objects).
>

It is arguable that cs.toString() may serve the purpose of taking a snapshot of an otherwise
"mutable" character buffer?

-Sherman

> Is changing this a desirable development? It seems pretty straightforward
> to port indexOf(String) to use CharSequence.
>
> If all you need is patch then I can work on it (I have signed OCA) just
> wanted to make sure it is not a futile work.
>