JDK 9 RFR of JDK-8075304: Remove duplicate test: FDTest
Robert Field
robert.field at oracle.com
Tue Mar 31 05:47:59 UTC 2015
Looks good.
-Robert
On 03/30/15 20:44, Amy Lu wrote:
> Not yet got review feedback, I updated the webrev to get more cleanup
> included.
>
> Updated webrev: http://cr.openjdk.java.net/~amlu/8075304/webrev.01/
>
> For your reference:
> For all tests proposed to be removed in this patch, here are the
> differences between the one exist in "jdk" repo and "langtools" repo:
> http://cr.openjdk.java.net/~amlu/8075304/8075304_test_diff_jdk_vs_langtools.txt
>
>
> Thanks,
> Amy
>
> On 3/24/15 3:54 PM, Amy Lu wrote:
>> Kindly reminder ...
>>
>> On 3/17/15 3:05 PM, Amy Lu wrote:
>>> This RFR proposes to remove the duplicate FDTest from “jdk” repo.
>>>
>>> FDTest exists in both “jdk” and “langtools”:
>>> http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/test/jdk/lambda/FDTest.java
>>>
>>> http://hg.openjdk.java.net/jdk9/dev/langtools/file/tip/test/tools/javac/lambdaShapes/org/openjdk/tests/javac/FDTest.java
>>>
>>>
>>> So far the only diff between the two tests is that the version in
>>> langtools has one more teardown method to well handle the resource
>>> close
>>> > @AfterSuite
>>> > static void teardown() throws IOException {
>>> > fm.close();
>>> > }
>>>
>>> As this test is for JavaCompiler, it makes more sense to keep the
>>> test in "langtools" and remove the duplicate one from "jdk”.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8075304
>>> webrev: http://cr.openjdk.java.net/~amlu/8075304/webrev.00/
>>>
>>>
>>> Thanks,
>>> Amy
>>
>
More information about the core-libs-dev
mailing list