RFR 8078645: removeIf(filter) in ConcurrentHashMap removes entries for which filter is false

Martin Buchholz martinrb at google.com
Mon May 4 17:12:56 UTC 2015


Thanks, Paul.

Are there are too many cooks spoiling this broth?
There are still a number of differences, mostly cosmetic, between your
version of ConcurrentMap.java and jsr166 CVS (let's try hard to keep that
the "master" copy).  E.g.  This code sample won't compile:

      *     do {
      *        K k = entry.getKey();
      *        V v = entry.getValue();
-     *     } while(!replace(k, v, function.apply(k, v)));

I would take the opportunity to sync all the changes from jsr166 CVS.
Or we could wait for the Great jsr166 CVS openjdk9 sync...



On Mon, May 4, 2015 at 8:59 AM, Paul Sandoz <paul.sandoz at oracle.com> wrote:

> Hi
>
> Please review:
>
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8078645-ConcurrentMap-views-removeIf/webrev/
>
> These updates are already in the 166 repo.
>
> The documentation update to the class of ConcurrentMap is going through
> CCC. I took the liberty of also cleaning up some smaller doc errors on
> ConcurrentMap as made in the 166 repo.
>
> Thanks,
> Paul.
>



More information about the core-libs-dev mailing list