RFR 8078645: removeIf(filter) in ConcurrentHashMap removes entries for which filter is false

[Paul Sandoz]

On May 4, 2015, at 7:12 PM, Martin Buchholz <martinrb at google.com> wrote:

> Thanks, Paul.
> 
> Are there are too many cooks spoiling this broth?

Probably :-)


> There are still a number of differences, mostly cosmetic, between your version of ConcurrentMap.java and jsr166 CVS (let's try hard to keep that the "master" copy).

Yeah, there are a bunch of cosmetic differences, i just tried to fix some of the JavaDoc-like errors and may have slipped in some other cosmetic things. Let me fully sync up ConcurrentMap from 166.



>   E.g.  This code sample won't compile:
> 
>       *     do {
>       *        K k = entry.getKey();
>       *        V v = entry.getValue();
> -     *     } while(!replace(k, v, function.apply(k, v)));
> 

I thought I fixed that in the patch.


> I would take the opportunity to sync all the changes from jsr166 CVS.

At some point, yes. Would prefer to do that a littler later.

Paul.

> Or we could wait for the Great jsr166 CVS openjdk9 sync...
>