RFR: 8079459: JCK test api/java_nio/ByteBuffer/index.html#GetPutXXX start failing after JDK-8026049
Alan Bateman
Alan.Bateman at oracle.com
Wed May 13 18:35:38 UTC 2015
On 13/05/2015 17:14, Andrew Haley wrote:
> :
> Test coverage is here extended to include boundary conditions for all primitive
> types:
>
> Fix:
>
> http://cr.openjdk.java.net/~aph/8079459-2-jdk/
>
> Testcase:
>
> http://cr.openjdk.java.net/~aph/8079459-2-hs/
>
Thanks for expanding the test coverage, just awkward to have the tests
split between the hotspot/compiler tree and jdk/test/java/nio/Buffer.
A few passing comments on the test
- Is errors incremented anywhere?
- You could reduce the code a bit by catching Throwable once. Also would
be good to have it be the cause for the RuntimeException so that the
original exception/error isn't lost.
- Personally I would reduce the line length but this area might be okay
with very long lines.
-Alan.
More information about the core-libs-dev
mailing list