RFR: 8079459: JCK test api/java_nio/ByteBuffer/index.html#GetPutXXX start failing after JDK-8026049
Andrew Haley
aph at redhat.com
Thu May 14 13:40:13 UTC 2015
On 05/13/2015 07:35 PM, Alan Bateman wrote:
>
>
> A few passing comments on the test
> - Is errors incremented anywhere?
Oops.
I realized after sending the email that I needed to strengthen the
test. If one of the four {get,put} operations fails then all four
should fail. I added a check for this.
> - You could reduce the code a bit by catching Throwable once. Also would
> be good to have it be the cause for the RuntimeException so that the
> original exception/error isn't lost.
OK.
> - Personally I would reduce the line length but this area might be okay
> with very long lines.
I tried.
Fix:
http://cr.openjdk.java.net/~aph/8079459-3-jdk/
Testcase:
http://cr.openjdk.java.net/~aph/8079459-3-hs/
Andrew.
More information about the core-libs-dev
mailing list