[verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

[Alejandro E Murillo]

On 11/3/2015 3:42 PM, Daniel D. Daugherty wrote:
> On 11/3/15 10:45 AM, Alejandro E Murillo wrote:
>> Please review these changes:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8139986
>> Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986/
>
> jdk/src/java.base/share/classes/sun/misc/Version.java.template
>     nit: L103:         if (jdk_debug_level.startsWith("release") )
>         Please delete extra space between right parens.
>
will fix that
> Also, looks like other single line if-statements in
>         this file uses this format:
>
>             if (expr) {
>                 statement;
>             }
right, will also fix that
thanks Dan!
Alejandro
>
> jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java
>     No comments.
>
> hotspot/make/aix/makefiles/vm.make
>     No comments.
>
> hotspot/make/bsd/makefiles/vm.make
>     No comments.
>
> hotspot/make/linux/makefiles/vm.make
>     No comments.
>
> hotspot/make/solaris/makefiles/vm.make
>     No comments.
>
> hotspot/make/windows/makefiles/defs.make
>     No comments.
>
> hotspot/make/windows/makefiles/vm.make
>     No comments.
>
> hotspot/make/windows/projectfiles/common/Makefile
>     No comments.
>
> hotspot/src/share/vm/runtime/arguments.cpp
>     No comments.
>
> hotspot/src/share/vm/runtime/statSampler.cpp
>     No comments.
>
> hotspot/src/share/vm/runtime/vm_version.cpp
>     nit L68   #error DEBUG_LEVEL  must be defined
>         Please delete the extra space before "must be..."
>
> hotspot/src/share/vm/runtime/vm_version.hpp
>     No comments.
>
> hotspot/test/testlibrary/jdk/test/lib/Platform.java
>     No comments.
>
>
> Thumbs up. If you fix the minor style issues above,
> I don't need to see another webrev.
>
> Dan
>
>
>>
>> Background:
>> These changes introduce a new system property named "jdk.debug" 
>> intended to
>> identify the type of the build. The build system has already been 
>> modified (see [1])
>> to provide the build type through the "--with-debug-level" configure 
>> option,
>> and  to remove that info from the (new) version string and
>> consequently from the "java.version" and "java.vm.version" system 
>> properties.
>>
>> Here, the configure debug level is used to initialize the value of 
>> the "jdk.debug" system
>> property. There are also changes to adapt any code that relied on the 
>> value of those version
>> properties to determine the  build type. They were changed to use 
>> this new property.
>>
>> The Launcher output was also modified to look as follows:
>>
>> jdk.debug = (“*foo*” != “release”)
>>             $java -version
>>             java version "9-ea"
>>             Java(TM) SE Runtime Environment (*foo *build 9-ea+88)
>>            Java HotSpot(TM) 64-Bit Server VM (*foo *build 9-ea+88, 
>> mixed mode)
>>
>> jdk.debug = “release”: (no change)
>>
>> $java -version
>> java version "9-ea"
>> Java(TM) SE Runtime Environment (build 9-ea+88)
>> Java HotSpot(TM) 64-Bit Server VM (build 9-ea+88, mixed mode)
>>
>>
>> All this will be described and updated in the JEP-223 doc [2] shortly.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8139951
>> [2] http://openjdk.java.net/jeps/223
>>
>> Thanks
>>
>

-- 
Alejandro