[verona.stage] RFR 8139986: Store debug level in java.vm.debug and conditionally print in "java -version"

David Holmes david.holmes at oracle.com
Wed Nov 4 03:52:35 UTC 2015


Looks good to me!

Thanks,
David

On 4/11/2015 3:45 AM, Alejandro E Murillo wrote:
> Please review these changes:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8139986
> Webrev: http://cr.openjdk.java.net/~amurillo/9/8139986/
>
> Background:
> These changes introduce a new system property named "jdk.debug" intended to
> identify the type of the build. The build system has already been
> modified (see [1])
> to provide the build type through the "--with-debug-level" configure
> option,
> and  to remove that info from the (new) version string and
> consequently from the "java.version" and "java.vm.version" system
> properties.
>
> Here, the configure debug level is used to initialize the value of the
> "jdk.debug" system
> property. There are also changes to adapt any code that relied on the
> value of those version
> properties to determine the  build type. They were changed to use this
> new property.
>
> The Launcher output was also modified to look as follows:
>
> jdk.debug = (“*foo*” != “release”)
>              $java -version
>              java version "9-ea"
>              Java(TM) SE Runtime Environment (*foo *build 9-ea+88)
>             Java HotSpot(TM) 64-Bit Server VM (*foo *build 9-ea+88,
> mixed mode)
>
> jdk.debug = “release”: (no change)
>
> $java -version
> java version "9-ea"
> Java(TM) SE Runtime Environment (build 9-ea+88)
> Java HotSpot(TM) 64-Bit Server VM (build 9-ea+88, mixed mode)
>
>
> All this will be described and updated in the JEP-223 doc [2] shortly.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8139951
> [2] http://openjdk.java.net/jeps/223
>
> Thanks
>



More information about the core-libs-dev mailing list