RFR: 8143926: ObjectStreamField constructor eagerly load ObjectStreamClass
Aleksey Shipilev
aleksey.shipilev at oracle.com
Wed Nov 25 15:06:00 UTC 2015
On 11/25/2015 05:44 PM, Claes Redestad wrote:
> please review this small cleanup/startup improvement which defers a few
> classes from loading during startup and consolidates some static utility
> methods to generate type signatures:
>
> webrev: http://cr.openjdk.java.net/~redestad/8143926/webrev.01/
> bug: https://bugs.openjdk.java.net/browse/JDK-8143926
Looks okay, even as the cleanup, not taking the performance improvements
into account.
Nit: don't you want to inline BD.getTypeChar into BD.unparseSig to avoid
"c != 'L')" comparison? Or you want to keep it separate as the utility
method?
Thanks,
-Aleksey
More information about the core-libs-dev
mailing list