RFR: 8143926: ObjectStreamField constructor eagerly load ObjectStreamClass

[Claes Redestad]

On 2015-11-25 16:06, Aleksey Shipilev wrote:
> On 11/25/2015 05:44 PM, Claes Redestad wrote:
>> please review this small cleanup/startup improvement which defers a few
>> classes from loading during startup and consolidates some static utility
>> methods to generate type signatures:
>>
>> webrev: http://cr.openjdk.java.net/~redestad/8143926/webrev.01/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8143926
> Looks okay, even as the cleanup, not taking the performance improvements
> into account.

Thanks!

>
> Nit: don't you want to inline BD.getTypeChar into BD.unparseSig to avoid
> "c != 'L')" comparison? Or you want to keep it separate as the utility
> method?

Inlining the isPrimitive check should be enough to avoid extra comparisons:

http://cr.openjdk.java.net/~redestad/8143926/webrev.02

/Claes