RFR(xxs): 8139037: [aix] Crash in ResolverConfigurationImpl.c - pointer shearing

[Lindenmaier, Goetz]

Hi Thomas,

the change looks good.  Thanks for fixing this.

Best regards,
  Goetz.


From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
Sent: Mittwoch, 7. Oktober 2015 16:28
To: Java Core Libs; ppc-aix-port-dev at openjdk.java.net
Subject: RFR(xxs): 8139037: [aix] Crash in ResolverConfigurationImpl.c - pointer shearing

Hi,

please review and sponsor this AIX fix.

in ResolverConfigurationImpl.c, we may crash because strchr() is used without prototype, which causes the C compiler to default to an int return type, which means we loose the upper 32bit of the pointer returned by strchr().

The solution is to include string.h.

Before, string.h was conditionally included for all platforms but AIX - reason is not really clear to me. But as strchr() is POSIX and always in string.h, I included string.h unconditionally for all Unices.


webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8139037/webrev.00/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8139037

Kind Regards, Thomas