RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

[Ivan Gerasimov]

Thanks!

It looks good to me now.

Sincerely yours,
Ivan

On 07.09.2015 16:08, Vyom Tewari wrote:
> Hi All,
>
> Please find the latest diff, which contains the  latest fix.
> http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
>
> Thanks,
> Vyom
>
>
> On 9/7/2015 3:48 PM, Alan Bateman wrote:
>> On 07/09/2015 10:26, Vyom Tewari wrote:
>>> Hi everyone,
>>> Can you please review my changes for below bug.
>>>
>>> Bug:
>>>      JDK-8080402 : File Leak in 
>>> jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
>>> Webrev:
>>> http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
>>>
>>> This change ensure that if close() fails we throw correct io 
>>> exception and there is no file leak.
>> close isn't restartable so I think we need to look at that while we 
>> are here.
>>
>> -Alan.
>
>