RFR 8080402: File Leak in jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java

[Mark Sheppard]

a couple of other considerations in the context of this issue perhaps?

in this s is being duped onto fd, and part of the dup2 operation is the 
closing of fd, but
what's is the expected state of file descriptor fd in the event of a 
dup2 failure?

s is closed in any case, but what about fd, should it be attended to if 
dup2 < 0
and closed ? is it still considered a valid fd?

what can be said about the state of the encapsulating FileDescriptor 
associated with fd?
at this stage can it still be considered valid?
should valid() return false?

regards
Mark

On 07/09/2015 14:29, Ivan Gerasimov wrote:
> Thanks!
>
> It looks good to me now.
>
> Sincerely yours,
> Ivan
>
> On 07.09.2015 16:08, Vyom Tewari wrote:
>> Hi All,
>>
>> Please find the latest diff, which contains the  latest fix.
>> http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
>>
>> Thanks,
>> Vyom
>>
>>
>> On 9/7/2015 3:48 PM, Alan Bateman wrote:
>>> On 07/09/2015 10:26, Vyom Tewari wrote:
>>>> Hi everyone,
>>>> Can you please review my changes for below bug.
>>>>
>>>> Bug:
>>>>      JDK-8080402 : File Leak in 
>>>> jdk/src/java.base/share/classes/sun/net/sdp/SdpSupport.java
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.01/
>>>>
>>>> This change ensure that if close() fails we throw correct io 
>>>> exception and there is no file leak.
>>> close isn't restartable so I think we need to look at that while we 
>>> are here.
>>>
>>> -Alan.
>>
>>
>