[9] RFR 8163518: Integer overflow in StringBufferInputStream.read(byte[], int, int) and CharArrayReader.read(char[], int, int)

Roger Riggs Roger.Riggs at Oracle.com
Wed Aug 10 13:43:39 UTC 2016


Hi Ivan,

The change looks fine.

For the tests, is there an @requires for memory that would allow the 
test to run if the heap was really large.
Mostly it would have the same effect at @ignore but would be explicit 
about its requirements.

Roger


On 8/9/2016 8:12 PM, Ivan Gerasimov wrote:
> Hello!
>
> Two classes from java.io package may experience the integer overflow 
> problem in their read() methods.
> Would you please help review the obvious fix?
>
> The regression tests are @ignored by default, as they require 4+ GB of 
> the heap to run.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8163518
> WEBREV: http://cr.openjdk.java.net/~igerasim/8163518/00/webrev/
>
> With kind regards,
> Ivan
>
>



More information about the core-libs-dev mailing list