[9] RFR 8163518: Integer overflow in StringBufferInputStream.read(byte[], int, int) and CharArrayReader.read(char[], int, int)
Ivan Gerasimov
ivan.gerasimov at oracle.com
Wed Aug 10 17:55:35 UTC 2016
Thank you Roger and Aleksey for reviews!
On 10.08.2016 16:43, Roger Riggs wrote:
> Hi Ivan,
>
> The change looks fine.
>
> For the tests, is there an @requires for memory that would allow the
> test to run if the heap was really large.
> Mostly it would have the same effect at @ignore but would be explicit
> about its requirements.
>
Good point.
I've just found out that there's os.maxMemory property recognized by
@requires tag, so I used it in place of @ignored.
Additionally, yet another source of numeric overflow was just discovered
(that is in CharArrayReader.skip()), so here's the updated webrev.
http://cr.openjdk.java.net/~igerasim/8163518/01/webrev/
Would you please help review it once again?
With kind regards,
Ivan
More information about the core-libs-dev
mailing list