[jdk9] RFR: 8164366: ZoneOffset.ofHoursMinutesSeconds() does not reject invalid input

[nadeesh tv]

Hi  Ivan,

ZoneOffset.ofTotalSeconds(Integer.MIN_VALUE) have also the same issue. It' not throwing the expected DTE.

May be you can correct this also as part of this.

Please update the copyright year also.

Rest looks good.

-- 
Thanks and Regards,
Nadeesh TV



On 8/18/2016 10:23 PM, Ivan Gerasimov wrote:
> Hello everybody!
>
> The factory methods of ZoneOffset class demonstrate a minor 
> inconsistency.
> Normally, invalid values of arguments are rejected (e.g. when minutes 
> > 59), but the value of Integer.MIN_VALUE is allowed to be passed in.
>
> This is due to using Math.abs(), which cannot handle Integer.MIN_VALUE 
> well.
>
> Would you please help review the fix?
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8164366
> WEBREV: http://cr.openjdk.java.net/~igerasim/8164366/00/webrev/
>
> With kind regards,
> Ivan
>

-- 
Thanks and Regards,
Nadeesh TV