RFR(S): 8160564: TEST: Add a test to check the implementation of VersionProps.versionNumbers()

Mandy Chung mandy.chung at oracle.com
Thu Jul 14 14:04:51 UTC 2016


> On Jul 12, 2016, at 9:54 PM, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
> Please find the new webrev at:
> 
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8160564.v2/
> 

Looks good.

Nit: maybe better to rename the parameter to “version”.
  79     static List<Integer> parseVersionNumbers(String versionNumber) {

No need to generate a new webrev.

thanks
Mandy



More information about the core-libs-dev mailing list