RFR(S): 8160564: TEST: Add a test to check the implementation of VersionProps.versionNumbers()

Volker Simonis volker.simonis at gmail.com
Thu Jul 14 14:21:31 UTC 2016


On Thu, Jul 14, 2016 at 4:04 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>
>> On Jul 12, 2016, at 9:54 PM, Volker Simonis <volker.simonis at gmail.com> wrote:
>>
>> Please find the new webrev at:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8160564.v2/
>>
>
> Looks good.
>
> Nit: maybe better to rename the parameter to “version”.
>   79     static List<Integer> parseVersionNumbers(String versionNumber) {
>
> No need to generate a new webrev.
>

Thanks for the review! I'll do so.

Regards,
Volker


> thanks
> Mandy
>


More information about the core-libs-dev mailing list