Review Request: JDK-8159524 jdeps -jdkinternals throws NPE when no replacement is known

[Daniel Fuchs]

Hi Mandy,

JdepsTask.java:

  616                     .filter(e -> e.getValue() != null)

    is this still needed? I thought the use of optional at line
    602 already filtered out the null values.

  617                     .sorted(Map.Entry.comparingByKey())

    I believe you could get rid of that line by simply
    turning jdkInternals into a TreeMap at line 599.

The rest looks reasonable to me.

best regards,

-- daniel


On 15/06/16 21:58, Mandy Chung wrote:
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159524/webrev.00/index.html
>
> Simple fix in jdeps -jdkinternals to handle properly when no replacement is known.
>
> Mandy
>