Review Request: JDK-8159524 jdeps -jdkinternals throws NPE when no replacement is known
Mandy Chung
mandy.chung at oracle.com
Fri Jun 17 16:59:31 UTC 2016
> On Jun 17, 2016, at 7:26 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> Hi Mandy,
>
> JdepsTask.java:
>
> 616 .filter(e -> e.getValue() != null)
>
> is this still needed? I thought the use of optional at line
> 602 already filtered out the null values.
>
Good catch. It’s no longer needed. Took out this filter.
> 617 .sorted(Map.Entry.comparingByKey())
>
> I believe you could get rid of that line by simply
> turning jdkInternals into a TreeMap at line 599.
>
This is fine with me too. Changed.
> The rest looks reasonable to me.
>
Thanks for the review.
Mandy
More information about the core-libs-dev
mailing list