RFR: JDK-8043329: Wrong variable used in java.util.Collections javadoc code

Lance @ Oracle lance.andersen at oracle.com
Thu Mar 10 11:35:01 UTC 2016


Looks ok


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad

> On Mar 10, 2016, at 5:51 AM, Sergey Ustimenko <merkel05 at gmail.com> wrote:
> 
> Hi everyone! Could someone plaese review this tiny
> javadoc fix and sponsor it? Patch is in attaches.
> 
> 
> 
> 
> diff --git a/src/java.base/share/classes/java/util/Collections.java
> b/src/java.base/share/classes/java/util/Collections.java
> --- a/src/java.base/share/classes/java/util/Collections.java
> +++ b/src/java.base/share/classes/java/util/Collections.java
> @@ -2728,7 +2728,7 @@
>      *  Set s2 = m2.keySet();  // Needn't be in synchronized block
>      *      ...
>      *  synchronized (m) {  // Synchronizing on m, not m2 or s2!
> -     *      Iterator i = s.iterator(); // Must be in synchronized block
> +     *      Iterator i = s2.iterator(); // Must be in synchronized block
>      *      while (i.hasNext())
>      *          foo(i.next());
>      *  }
> <JDK-8043329.diff>



More information about the core-libs-dev mailing list