RFR: JDK-8043329: Wrong variable used in java.util.Collections javadoc code

Sergey Ustimenko merkel05 at gmail.com
Thu Mar 10 11:48:30 UTC 2016


Thank you, Lance.

I would like second review and a sponsor for this one.
(bug: https://bugs.openjdk.java.net/browse/JDK-8043329)

Regards,
Sergey.

2016-03-10 14:35 GMT+03:00 Lance @ Oracle <lance.andersen at oracle.com>:

> Looks ok
>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
> Sent from my iPad
>
> On Mar 10, 2016, at 5:51 AM, Sergey Ustimenko <merkel05 at gmail.com> wrote:
>
> Hi everyone! Could someone plaese review this tiny
> javadoc fix and sponsor it? Patch is in attaches.
>
>
>
>
> diff --git a/src/java.base/share/classes/java/util/Collections.java
> b/src/java.base/share/classes/java/util/Collections.java
> --- a/src/java.base/share/classes/java/util/Collections.java
> +++ b/src/java.base/share/classes/java/util/Collections.java
> @@ -2728,7 +2728,7 @@
>      *  Set s2 = m2.keySet();  // Needn't be in synchronized block
>      *      ...
>      *  synchronized (m) {  // Synchronizing on m, not m2 or s2!
> -     *      Iterator i = s.iterator(); // Must be in synchronized block
> +     *      Iterator i = s2.iterator(); // Must be in synchronized block
>      *      while (i.hasNext())
>      *          foo(i.next());
>      *  }
>
> <JDK-8043329.diff>
>
>



More information about the core-libs-dev mailing list