RFR(M): 8156915: introduce MethodHandle factory for array length

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Wed May 18 09:47:43 UTC 2016


src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java
+            throw new AssertionError();

+            throw new IllegalStateException("should not reach here");

Please, use InternalError to signal about error conditions (there's 
MHS.newInternalError(String)) and put a message containing description 
of problematic parameters to simplify problem diagnostics.

Otherwise, looks good!

Best regards,
Vladimir Ivanov

On 5/18/16 10:52 AM, Michael Haupt wrote:
> Dear all,
>
> please review this change.
> RFE: https://bugs.openjdk.java.net/browse/JDK-8156915
> Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webrev.00/
>
> Thanks,
>
> Michael
>



More information about the core-libs-dev mailing list