RFR(M): 8156915: introduce MethodHandle factory for array length

[Uwe Schindler]

Hi,

I noticed the same when skimming through the patch! I'd change this, too.

Uwe

-----
Uwe Schindler
uschindler at apache.org 
ASF Member, Apache Lucene PMC / Committer
Bremen, Germany
http://lucene.apache.org/
> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On
> Behalf Of Sundararajan Athijegannathan
> Sent: Wednesday, May 18, 2016 10:07 AM
> To: core-libs-dev at openjdk.java.net
> Subject: Re: RFR(M): 8156915: introduce MethodHandle factory for array
> length
> 
> +1
> 
> Minor comment:
> 
> File: MethodHandleImpl.java
> 
> If "checks" can be inside the assert. + if (access == ArrayAccess.SET)
> assert(mh.type().parameterType(2) == Object.class);
> + if (access == ArrayAccess.GET) {
> + assert(mh.type().returnType() == Object.class);
> + assert(correctType.parameterType(0).getComponentType() ==
> correctType.returnType());
> + } -Sundar
> 
> 
> On 5/18/2016 1:22 PM, Michael Haupt wrote:
> > Dear all,
> >
> > please review this change.
> > RFE: https://bugs.openjdk.java.net/browse/JDK-8156915
> > Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webrev.00/
> >
> > Thanks,
> >
> > Michael
> >