RFR(s): 8169055: [TESTBUG] : java/io/Serializable/serialFilter/ tests have undeclared dependency on jdk.jdeps module

[Daniel Fuchs]

Hi Sergey,

On 02/11/16 12:31, Sergei Kovalev wrote:
> Hi Daniel,
>
> Thank you for looking this.
>
> We have six java files: CheckInputOrderTest.java,
> FilterWithSecurityManagerTest.java, GlobalFilterTest.java,
> MixedFiltersTest.java, SerialFilterTest.java.
>
> Last one has declared import:
>
> import javax.lang.model.SourceVersion;
>
> that is a part of jdk.jdeps module. All other java files has a line
> like: "@build FilterWithSecurityManagerTest SerialFilterTest" that means
> that the test requires the SerialFilterTest.java being compiled and
> therefore it depends on jdeps module too.
>
> Could you please point me which particular imports belong to
> jdk.compiler module?

javax.lang.model is exported by java.compiler, not jdk.jdeps.

http://hg.openjdk.java.net/jdk9/dev/langtools/file/tip/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java

>
> For execution I've use the command line
>
> jtreg -jdk:/home/skovalev/TRASH/jdk9_latest -verbose:all
> -javaoptions:"--limit-modules java.base,jdk.jdeps"
> -javacoptions:"--limit-modules java.base,jdk.jdeps"
> /home/skovalev/repos/jdk9-dev/jdk/test/java/io/Serializable/serialFilter
>
> and the tests compiled successfully without jdk.compiler. What should I
> change in my environment to highlight dependency from the module?

jdk.jdeps requires java.compiler, and IMO this is why this working.
But as far as I can tell nothing depends on jdk.jdeps in these tests.

cheers,

-- daniel

>
> 02.11.16 14:45, Daniel Fuchs wrote:
>> Hi Sergey,
>>
>> I do not see any dependency on jdk.jdeps in the test sources.
>> What I do see is a dependency on java.compiler though.
>>
>> So why @modules jdk.jdeps and not @modules java.compiler?
>>
>> best regards,
>>
>> -- daniel
>>
>>
>> On 02/11/16 11:22, Sergei Kovalev wrote:
>>> Hi team,
>>>
>>> Please review a very small fix for tests related to java/io/Serializable
>>> pack.
>>>
>>> BugID: https://bugs.openjdk.java.net/browse/JDK-8169055
>>> WebRev: http://cr.openjdk.java.net/~skovalev/8169055/webrev.00/
>>>
>>> Issue: Several tests failing in case usage of "--limit-modules" command
>>> line option.
>>> Solution: add missed declaration into test jtreg header.
>>>
>>
>
> --
> With best regards,
> Sergei
>