RFR(s): 8169055: [TESTBUG] : java/io/Serializable/serialFilter/ tests have undeclared dependency on jdk.jdeps module

Chris Hegarty chris.hegarty at oracle.com
Wed Nov 2 22:19:42 UTC 2016


> On 2 Nov 2016, at 18:14, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> On 02/11/16 17:39, Roger Riggs wrote:
>> Hi,
>> 
>> I would rather switch the test to use a type in the base module.
>> Switching from SourceVersion to javax.net.ssl.SSLEngineResult enables
>> the test to run
>> without additional @modules.
>> 
>> Webrev/patch:
>> http://cr.openjdk.java.net/~rriggs/webrev-filter-classes-8169055/
> 
> +1

++1

-Chris.

> -- daniel
> 
>> 
>> Roger
>> 
>> 
>> On 11/2/2016 9:31 AM, Sergei Kovalev wrote:
>>> Thank you all,
>>> 
>>> java.compiler is enough.
>>> 
>>> http://cr.openjdk.java.net/~skovalev/8169055/webrev.02/
>>> 
>>> 
>>> 02.11.16 16:25, Daniel Fuchs wrote:
>>>> Hi Sergey,
>>>> 
>>>> Why jdk.compiler? Why not simply java.compiler?
>>>> 
>>>> best regards,
>>>> 
>>>> -- daniel
>>>> 
>>>> On 02/11/16 12:51, Sergei Kovalev wrote:
>>>>> Fixed
>>>>> 
>>>>> http://cr.openjdk.java.net/~skovalev/8169055/webrev.01/
>>>>> 
>>>>> 
>>>>> 02.11.16 15:34, Chris Hegarty wrote:
>>>>>>> On 2 Nov 2016, at 12:31, Sergei Kovalev <sergei.kovalev at oracle.com>
>>>>>>> wrote:
>>>>>>> 
>>>>>>> javax.lang.model.SourceVersion
>>>>>> This type is in the java.compiler module.
>>>>>> 
>>>>>> -Chris.
>>>>> 
>>>> 
>>> 
>> 
> 



More information about the core-libs-dev mailing list