[9] RFR: 8168923: Use unsigned random long in a temp directory name

Brian Burkhalter brian.burkhalter at oracle.com
Wed Nov 2 14:51:05 UTC 2016


Hi Ivan,

This all looks good. +1.

Thanks,

Brian

On Nov 2, 2016, at 7:39 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:

> Thank you Brian for review!
> 
> 
> On 31.10.2016 21:23, Brian Burkhalter wrote:
>> One more thing …
>> 
>> In [1] lines 58-59 could be corrected in the same way.
> 
> Yes, right.  Thanks for catching it!
> 
> Here's the updated webrev:
> http://cr.openjdk.java.net/~igerasim/8168923/01/webrev/
> 
>> Thanks,
>> 
>> Brian
>> 
>> [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/0086eb10182b/src/java.base/share/classes/java/nio/file/TempFileHelper.java
>> 
>> On Oct 31, 2016, at 9:00 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> 
>>> Hello, Ivan,
>>> 
>>> Aside from the inevitable copyright year update this looks fine to me.
>>> What effect does it have on the regression test run?
> 
> Tested (jdk_io|jdk_nio) on all platforms, no failures.



More information about the core-libs-dev mailing list