RFR (JAXP) 8171243 : CatalogManager.catalogResolver throws FileSystemNotFoundException with jar

[huizhe wang]

On 1/9/2017 10:02 AM, Daniel Fuchs wrote:
> Hi Joe,
>
> BaseEntry.java:
>
>  213      * @return The URI created from the specified uri
>  214      * @throws IllegalArgumentException if the specified uri is 
> null,
>  215      * or a URL can not be created based on the specified base 
> and uri
>  216      */
>  217     URL verifyURI(String arg, URL base, String uri) {
>  218         CatalogMessages.reportNPEOnNull(arg, uri);

Good catch. I'm changing the docs to:
      * @throws NullPointerException if the specified uri is null
      * @throws IllegalArgumentException if a URL can not be created 
based on
      * the specified base and uri

NPE is required for the consistency throughout the API for handling null 
input.

>
> line 214 seems to contradict line 218...
>
> What is the consequence of only allowing absolute URIs?
> Is it something that might cause backward compatibility issues?

While the top interfaces requires that the URIs must be absolute, they 
can prevent relative URIs from happening in a catalog file, which is 
allowed by the Catalog Standard.

Best,
Joe

>
> best regards,
>
> -- daniel
>
>
> On 09/01/17 17:38, huizhe wang wrote:
>> Hi,
>>
>> The current Catalog API accepts file paths or URIs in a form of String
>> to create Catalog or CatalogResolver in an effort to maintain
>> consistency with the old Catalog API and other existing processors.
>> However, that also introduced an ambiguity in the API, which is unwanted
>> for a new API in Java SE 9.
>>
>> Please review the changes.
>> In jaxp repo:
>> http://cr.openjdk.java.net/~joehw/jdk9/8171243/webrev/
>>
>> In jaxws repo:
>> http://cr.openjdk.java.net/~joehw/jdk9/8171243_jaxws/webrev/
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8171243
>>
>> Thanks,
>> Joe
>>
>