RFR (JAXP) 8171243 : CatalogManager.catalogResolver throws FileSystemNotFoundException with jar

[Roger Riggs]

Hi Joe,

a few comments:

CatalogManager:
  - line 58:  "will /return /as no mapping is found";
   Or is it describing the behavior of the CatalogResolver (which is 
throw a CatalogException)?
    (possible more than 1 place)

Check the copyrights -> 2017  (JarUtils.java)

in JAXWS repo:
  - Options.java:  line 786 - you could use URI[]::new instead of 
creating a placeholder URI[0].

Looks good,  Roger


On 1/9/2017 12:38 PM, huizhe wang wrote:
> Hi,
>
> The current Catalog API accepts file paths or URIs in a form of String 
> to create Catalog or CatalogResolver in an effort to maintain 
> consistency with the old Catalog API and other existing processors. 
> However, that also introduced an ambiguity in the API, which is 
> unwanted for a new API in Java SE 9.
>
> Please review the changes.
> In jaxp repo:
> http://cr.openjdk.java.net/~joehw/jdk9/8171243/webrev/
>
> In jaxws repo:
> http://cr.openjdk.java.net/~joehw/jdk9/8171243_jaxws/webrev/
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8171243
>
> Thanks,
> Joe
>