RFR: JDK-8172432,jar cleanup/update for module and mrm jar
Mandy Chung
mandy.chung at oracle.com
Thu Jan 12 21:46:47 UTC 2017
> On Jan 10, 2017, at 10:00 PM, Xueming Shen <xueming.shen at oracle.com> wrote:
>
>
> webrev has been updated to catch IMDE and fails the jar as other fatal error handing.
>
> http://cr.openjdk.java.net/~sherman/8172432/webrev <http://cr.openjdk.java.net/~sherman/8172432/webrev>
>
This version includes new fixes for JDK-8171830 and JDK-8165640. Thanks for doing that. The fix for JDK-8171830 looks fine.
For JDK-8165640, it looks like checkModuleInfo can be refactored / moved to Validator so that the validation code is consistent and shared for checking in both places (MMR validation and module-info.class).
Since it’s a separate issue, you should consider just to pushing the changeset for JDK-8172432 and JDK-8171830. Resolve JDK-8165640 in a separate patch that will make the review easier too.
Mandy
More information about the core-libs-dev
mailing list