(JAXP) RFR: 8173111: Excessive recursion in EventFilterSupport when filtering over large number of XML events can cause StackOverflow

[Langer, Christoph]

Hi Daniel,

your fix looks good, pretty straightforward, +1.

A minor thing, src/java.xml/share/classes/com/sun/xml/internal/stream/EventFilterSupport.java:
67         while (super.hasNext()){
As you are touching this line, you could add a blank between ')' and '{'.

Disclaimer: I'm no reviewer.

Best regards
Christoph

> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On Behalf
> Of Daniel Fuchs
> Sent: Montag, 23. Januar 2017 18:48
> To: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: (JAXP) RFR: 8173111: Excessive recursion in EventFilterSupport when
> filtering over large number of XML events can cause StackOverflow
> 
> Hi,
> 
> Please find below a fix for:
> 
> 8173111: Excessive recursion in EventFilterSupport when filtering
>           over large number of XML events can cause StackOverflow
> https://bugs.openjdk.java.net/browse/JDK-8173111
> 
> The fix is almost trivial: it replaces a recursion by a loop in
> two places.
> 
> http://cr.openjdk.java.net/~dfuchs/webrev_8173111/webrev.00/
> 
> The test will fail without the fix (at least on my machine)
> and pass with it (on my machine and in our test system).
> 
> best regards,
> 
> -- daniel