(JAXP) RFR: 8173111: Excessive recursion in EventFilterSupport when filtering over large number of XML events can cause StackOverflow

[Daniel Fuchs]

Hi,

Thanks for all the feedback.

I have updated the webrev
http://cr.openjdk.java.net/~dfuchs/webrev_8173111/webrev.01

The test now uses assertEquals as suggested by Lance and Aleksej
(thanks for the suggestion).
I also fixed the missing white space in the code that Christoph
spotted at line 67.
I kept the main method (useful when you tweak the test in
NetBeans).

I'm going to launch it again through our test system and if
successful I'll consider it reviewed and push it, unless I
hear otherwise by then :-)

best regards,

-- daniel



On 23/01/17 17:48, Daniel Fuchs wrote:
> Hi,
>
> Please find below a fix for:
>
> 8173111: Excessive recursion in EventFilterSupport when filtering
>          over large number of XML events can cause StackOverflow
> https://bugs.openjdk.java.net/browse/JDK-8173111
>
> The fix is almost trivial: it replaces a recursion by a loop in
> two places.
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8173111/webrev.00/
>
> The test will fail without the fix (at least on my machine)
> and pass with it (on my machine and in our test system).
>
> best regards,
>
> -- daniel