RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Chris Hegarty chris.hegarty at oracle.com
Tue Jun 6 08:15:26 UTC 2017


> On 1 Jun 2017, at 09:32, Felix Yang <felix.yang at oracle.com> wrote:
> 
> Hi there,
> 
>    please review the patch convert several sun/net shell tests to plain java tests.
> 
> Bug:
> 
>    https://bugs.openjdk.java.net/browse/JDK-8181080
> 
> Webrev:
> 
>    http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/


OtherResourcesTest.java is not strictly needed. You should be able to 
provide an appropriate @run tag to OtherResources.java directly, like:

  @run main/othervm --limit-modules=java.base OtherResources

DirPermissionDenied.java
  If you are going to delete the dir, then please use the FileUtils.deleteXXX
  from the test library.

Thanks,
-Chris.


More information about the core-libs-dev mailing list