8179527: Ineffective use of volatile hurts performance of Charset.atBugLevel()

Roger Riggs Roger.Riggs at Oracle.com
Thu Jun 29 13:41:45 UTC 2017


Hi Christoph,

Reviewed:  The Reviewer field is visible when the issue is "Edited" or 
has an entry in it.

I think I would have would have titled the issue to highlight the 
removal of support for the sun.nio.cs.bugLevel property and the related 
change in exception behavior.  That's the compatibility issue (not 
performance).

Typically, if a patch is included it should include only the parts that 
modify the specification.
Reviewers should not be influenced by the implementation details.

Thanks, Roger

On 6/29/2017 8:07 AM, Langer, Christoph wrote:
> Hi,
>
> can somebody please review my CSR: https://bugs.openjdk.java.net/browse/JDK-8183116 ?
>
> I think there should be some button to add yourself as reviewer in the CSR bug - though I have never done such a thing myself. You'll probably know what to do :)
>
> Thanks & Best regards
> Christoph
>
>
>> -----Original Message-----
>> From: Langer, Christoph
>> Sent: Mittwoch, 28. Juni 2017 11:24
>> To: 'Alan Bateman' <Alan.Bateman at oracle.com>; Kazunori Ogata
>> <OGATAK at jp.ibm.com>
>> Cc: ppc-aix-port-dev at openjdk.java.net; Claes Redestad
>> <claes.redestad at oracle.com>; core-libs-dev <core-libs-
>> dev at openjdk.java.net>; nio-dev at openjdk.java.net
>> Subject: RE: 8179527: Ineffective use of volatile hurts performance of
>> Charset.atBugLevel()
>>
>> Hi,
>>
>> I just filed the CSR: https://bugs.openjdk.java.net/browse/JDK-8183116. I set
>> it to status "Proposed". I assume it will be handled by the csr group
>> automatically?
>>
>> Best regards
>> Christoph
>>



More information about the core-libs-dev mailing list