8179527: Ineffective use of volatile hurts performance of Charset.atBugLevel()

[Langer, Christoph]

Hi Roger,

I first oversaw your mail but I think it pretty much matches with Alan's suggestions.

I have made some updates which I think address your points. I'm not able to remove the attachment of the patch, though.

 Let me know if something else should be changed.

Thanks & Best regards
Christoph

> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On
> Behalf Of Roger Riggs
> Sent: Donnerstag, 29. Juni 2017 15:42
> To: core-libs-dev at openjdk.java.net
> Subject: Re: 8179527: Ineffective use of volatile hurts performance of
> Charset.atBugLevel()
> 
> Hi Christoph,
> 
> Reviewed:  The Reviewer field is visible when the issue is "Edited" or
> has an entry in it.
> 
> I think I would have would have titled the issue to highlight the
> removal of support for the sun.nio.cs.bugLevel property and the related
> change in exception behavior.  That's the compatibility issue (not
> performance).
> 
> Typically, if a patch is included it should include only the parts that
> modify the specification.
> Reviewers should not be influenced by the implementation details.
> 
> Thanks, Roger
> 
> On 6/29/2017 8:07 AM, Langer, Christoph wrote:
> > Hi,
> >
> > can somebody please review my CSR:
> https://bugs.openjdk.java.net/browse/JDK-8183116 ?
> >
> > I think there should be some button to add yourself as reviewer in the CSR
> bug - though I have never done such a thing myself. You'll probably know
> what to do :)
> >
> > Thanks & Best regards
> > Christoph
> >