JDK-8067661: transferTo proposal for Appendable
Patrick Reinhart
patrick at reini.net
Mon Nov 13 22:23:40 UTC 2017
Latest changes:
http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.03
-Patrick
> Am 13.11.2017 um 15:35 schrieb Roger Riggs <Roger.Riggs at Oracle.com>:
>
> Hi Patrick,
>
> Comments on http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.02:
>
> Readable.java:
> 74: „to an error" is a bit overloaded, perhaps "to an exception“
done
>
> X-Buffer.java.template:
>
> 1567: „this buffer": do you mean the "out buffer“
done
>
> 1578: "The out buffer is this buffer": will read poorly out of context, perhaps: „Illegal transfer of a buffer to itself“
done
>
> 1580: Perhaps confine "start" to the else case.
>
> For the tests, an example of using RandomFactory is in test/jdk/java/io/InputStream/ReadNBytes.java.
changed the test accordingly
>
> Thanks, Roger
>
More information about the core-libs-dev
mailing list