RFR: 8184693: (opt) add Optional.isEmpty

[forax at univ-mlv.fr]

Hi Vivek,

Looks good to me,
nitpicking, when creating the list with List.of() in the tests, a space after each comma is missing 
  var list = List.of(2, 3, 4);

cheers,
Rémi

----- Mail original -----
> De: "Vivek Theeyarath" <vivek.theeyarath at oracle.com>
> À: "Remi Forax" <forax at univ-mlv.fr>, "core-libs-dev" <core-libs-dev at openjdk.java.net>
> Envoyé: Dimanche 15 Avril 2018 12:25:09
> Objet: RE: RFR: 8184693: (opt) add Optional.isEmpty

> Hi All,
>	Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
> 
> Regards
> Vivek
> -----Original Message-----
> From: Vivek Theeyarath
> Sent: Saturday, April 14, 2018 6:24 PM
> To: Remi Forax <forax at univ-mlv.fr>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: RE: RFR: 8184693: (opt) add Optional.isEmpty
> 
> I missed that Remi. Thanks for pointing it out. Will address those and get back.
> 
> Regards
> Vivek
> -----Original Message-----
> From: Remi Forax [mailto:forax at univ-mlv.fr]
> Sent: Saturday, April 14, 2018 2:58 PM
> To: Vivek Theeyarath <vivek.theeyarath at oracle.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
> 
> Hi Vivek,
> OptionalInt, OptionalLong and OptionalDouble should be changed too.
> 
> Rémi
> 
> ----- Mail original -----
>> De: "Vivek Theeyarath" <vivek.theeyarath at oracle.com>
>> À: "core-libs-dev" <core-libs-dev at openjdk.java.net>
>> Envoyé: Samedi 14 Avril 2018 08:22:50
>> Objet: RFR: 8184693: (opt) add Optional.isEmpty
> 
>> Hi All,
>> 
>>               Please review.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8184693
>> 
>> Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/
>> 
>> 
>> 
>> The related jtreg test was run and the test passed .
>> 
>> 
>> 
>> Regards
>> 
> > Vivek