RFR: 8184693: (opt) add Optional.isEmpty

Chris Hegarty chris.hegarty at oracle.com
Sun Apr 15 13:18:14 UTC 2018



> On 15 Apr 2018, at 11:25, Vivek Theeyarath <vivek.theeyarath at oracle.com> wrote:
> 
> Hi All,
>    Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/ 

This looks ok to me.

For consistency, can you please update the copyright header year range in OptionalInt.

-Chris.

> Regards
> Vivek
> -----Original Message-----
> From: Vivek Theeyarath 
> Sent: Saturday, April 14, 2018 6:24 PM
> To: Remi Forax <forax at univ-mlv.fr>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: RE: RFR: 8184693: (opt) add Optional.isEmpty
> 
> I missed that Remi. Thanks for pointing it out. Will address those and get back.
> 
> Regards
> Vivek
> -----Original Message-----
> From: Remi Forax [mailto:forax at univ-mlv.fr] 
> Sent: Saturday, April 14, 2018 2:58 PM
> To: Vivek Theeyarath <vivek.theeyarath at oracle.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
> 
> Hi Vivek,
> OptionalInt, OptionalLong and OptionalDouble should be changed too.
> 
> Rémi
> 
> ----- Mail original -----
>> De: "Vivek Theeyarath" <vivek.theeyarath at oracle.com>
>> À: "core-libs-dev" <core-libs-dev at openjdk.java.net>
>> Envoyé: Samedi 14 Avril 2018 08:22:50
>> Objet: RFR: 8184693: (opt) add Optional.isEmpty
> 
>> Hi All,
>> 
>>              Please review.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8184693
>> 
>> Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.00/
>> 
>> 
>> 
>> The related jtreg test was run and the test passed .
>> 
>> 
>> 
>> Regards
>> 
>> Vivek



More information about the core-libs-dev mailing list