RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Tue Apr 17 18:09:51 UTC 2018

Hi Volker,

Thank you for reviewing the patch. 

> you change looks good, although I can't really verify all the charset
> aliases. For example Wikipedia mentions that "ibm-932" is equivalent
> to "ibm-942" [1] but you made it an alias for "ibm-942C". What's
> actually the difference between "ibm-942C" and "ibm-942"?

IBM-942C is a customized version of IBM-942, in which following characters are replaced with ASCII thus making first 96 character mappings same as ASCII.

0x1A is mapped to 0x1C (in IBM-942) and to 0x1A (in IBM-942C)
0x1C is mapped to 0x7F (in IBM-942) and to 0x1C (in IBM-942C)
0x5C is mapped to 0xA5 (in IBM-942) and to 0x5C (in IBM-942C)
0x7E is mapped to 0x203E (in IBM-942) and to 0x7E (in IBM-942C)
0x7F is mapped to 0x1A (in IBM-942) and to 0x7F (in IBM-942C)

Similarly, IBM-943C is a customization for IBM-943 in which character mappings for Yen(¥) and overline(‾) are replaced by their ASCII equivalents backslash (\) and tilde (~). So, we should be mapping OS code-page IBM-943 to code-page IBM-943C in Java. I am working on fixing these inconsistencies in another defect in-order not to confuse things (I hope it is alright). Current patch mainly address moving default codepage from extended codepage list to standard codepage list. Also, There are few codepages which are missing in OpenJDK.

> I can sponsor your change although I would appreciate if somebody else
> from IBM could have another look at your change. I tried to compare
> with "IBM Java 9" but it doesn't seem to exist. They only refer to
> AdoptOpenJDK and AdoptOpenJDK just uses a vanilla version of OpenJDK.

Right! OpenJ9 version of JDK9 in AdoptOpenJDK is vanilla version of OpenJDK with OpenJ9. I've picked aliases for this patch from IBM JDK 8.

> Finally, I hope you won't mind if I update the copyright years on the
> files you changed before pushing (this is a convention in the OpenJDK
> project).

Sorry, I forgot to take care of copyright. Please change it this time before pushing. I will take care of it henceforth.

Thanks,
Bhaktavatsal Reddy

-----Volker Simonis <volker.simonis at gmail.com> wrote: -----
To: Bhaktavatsal R Maram <bhamaram at in.ibm.com>
From: Volker Simonis <volker.simonis at gmail.com>
Date: 04/17/2018 08:30PM
Cc: Alan Bateman <Alan.Bateman at oracle.com>, Tim Ellison <Tim_Ellison at uk.ibm.com>, ppc-aix-port-dev at openjdk.java.net, Java Core Libs <core-libs-dev at openjdk.java.net>
Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

Hi Bhaktavatsal Reddy,

you change looks good, although I can't really verify all the charset
aliases. For example Wikipedia mentions that "ibm-932" is equivalent
to "ibm-942" [1] but you made it an alias for "ibm-942C". What's
actually the difference between "ibm-942C" and "ibm-942"?

I can sponsor your change although I would appreciate if somebody else
from IBM could have another look at your change. I tried to compare
with "IBM Java 9" but it doesn't seem to exist. They only refer to
AdoptOpenJDK and AdoptOpenJDK just uses a vanilla version of OpenJDK.

Finally, I hope you won't mind if I update the copyright years on the
files you changed before pushing (this is a convention in the OpenJDK
project).

Best regards,
Volker

[1] https://urldefense.proofpoint.com/v2/url?u=https-3A__en.wikipedia.org_wiki_Code-5Fpage-5F932-5F-28IBM-29&d=DwIBaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg&m=DencrOI40Trgt_TxNW4dYVWqYtpT7dPnHzaSOEsw_ZQ&s=xYfspcI7N7ZAbVMqyjM7YIb_kd-RsFPn6pINIFz_Oa4&e=

On Mon, Apr 16, 2018 at 1:10 PM, Bhaktavatsal R Maram
<bhamaram at in.ibm.com> wrote:
> Hi All,
>
> I've regenerated webrev using "hg rename" to create template files. webrev looks much neat now.. Thanks Alan for suggestion.
>
> webrev - https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Egromero_8201540_v2_&d=DwIBaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=KUVGEwJiRVpNtQ9wUhGP6BKqzSTV1OWX31WWPdQMmqg&m=DencrOI40Trgt_TxNW4dYVWqYtpT7dPnHzaSOEsw_ZQ&s=mDikak1wXAwU-a0yd6dJml9X5N1DJg-GkQmgPl4v_5g&e=
>
> Thanks,
> Bhaktavatsal Reddy
>
>
> -----"core-libs-dev" <core-libs-dev-bounces at openjdk.java.net> wrote: -----
> To: Alan Bateman <Alan.Bateman at oracle.com>
> From: "Bhaktavatsal R Maram"
> Sent by: "core-libs-dev"
> Date: 04/16/2018 02:38PM
> Cc: Tim Ellison <Tim_Ellison at uk.ibm.com>, ppc-aix-port-dev at openjdk.java.net, Java Core Libs <core-libs-dev at openjdk.java.net>
> Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base
>
> Hi Alan,
>
> I deleted IBM943C.java (using hg remove) and added new file IBM943C.java.template (using hg add). I now understand that using "hg rename" is giving more meaningful representation in webrev/index.html.
>
> I will re-generate webrev by renaming source files to templates using "hg rename"
>
> Thanks,
> Bhaktavatsal Reddy
>
>
>
> -----Alan Bateman <Alan.Bateman at oracle.com> wrote: -----
> To: Bhaktavatsal R Maram <bhamaram at in.ibm.com>, Volker Simonis <volker.simonis at gmail.com>
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Date: 04/16/2018 02:16PM
> Cc: Java Core Libs <core-libs-dev at openjdk.java.net>, Tim Ellison <Tim_Ellison at uk.ibm.com>, ppc-aix-port-dev at openjdk.java.net
> Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base
>
>
> On 16/04/2018 09:22, Bhaktavatsal R Maram wrote:
>>
>> 3. Source files for IBM-942C and IBM-943C are changed to template to support #1
>>
> You might want to double check the webrev as it looks like you've added
> templates where as I assume you mean to use "hg rename" to rename
> IBM942C.java and IBM943C.java.
>
> -Alan
>
>
>