RFR(S): 8201540: [AIX] Extend the set of supported charsets in java.base

[Ichiroh Takiguchi]

Hello Volker.
(I'm sorry for duplicate posting, I did bad operation)

>> What's actually the difference between "ibm-942C" and "ibm-942"?
They have two differences on single byte part:
1. Control Character rotation for 0x1A and 0x1C, 0x7F [2]
2. Character replacement for 0x5C and 0x7E (0xFE, 0xFF)

For IBM-942 [3],
0x1A<=>U+001C,0x1C<=>U+007F,0x5C<=>U+00A5,0x7E<=>U+203E,0x7F<=>U+001A
0xFE<=>U+005C,0xFF<=>U+007E

For IBM-942C,
0x1A<=>U+001A,0x1C<=>U+001C,0x5C<=>U+005C,0x7E<=>U+007E,0x7F<=>U+007F,
0x5C<=U+00A5,0x7E<=U+203E
0xFE=>U+005C,0xFF=>U+007E
(It's ASCII compatible)

IBM-942's single byte part is IBM-1041 [4].
IBM-932's single byte part is IBM-897 [5].

IBM-1041 is not same as IBM-897.
5 characters were added into IBM-1041 [4].
(0x80,0xA0,0xFD,0xFE,0xFF [2])

[2] https://www-01.ibm.com/software/globalization/cdra/appendix_g.html
[3] https://en.wikipedia.org/wiki/Code_page_942
[4] http://www-01.ibm.com/software/globalization/cp/cp01041.html
[5] http://www-01.ibm.com/software/globalization/cp/cp00897.html

On 2018-04-17 23:52, Volker Simonis wrote:
> Hi Bhaktavatsal Reddy,
> 
> you change looks good, although I can't really verify all the charset
> aliases. For example Wikipedia mentions that "ibm-932" is equivalent
> to "ibm-942" [1] but you made it an alias for "ibm-942C". What's
> actually the difference between "ibm-942C" and "ibm-942"?
> 
> I can sponsor your change although I would appreciate if somebody else
> from IBM could have another look at your change. I tried to compare
> with "IBM Java 9" but it doesn't seem to exist. They only refer to
> AdoptOpenJDK and AdoptOpenJDK just uses a vanilla version of OpenJDK.
> 
> Finally, I hope you won't mind if I update the copyright years on the
> files you changed before pushing (this is a convention in the OpenJDK
> project).
> 
> Best regards,
> Volker
> 
> [1] https://en.wikipedia.org/wiki/Code_page_932_(IBM)
> 
> On Mon, Apr 16, 2018 at 1:10 PM, Bhaktavatsal R Maram
> <bhamaram at in.ibm.com> wrote:
>> Hi All,
>> 
>> I've regenerated webrev using "hg rename" to create template files. 
>> webrev looks much neat now.. Thanks Alan for suggestion.
>> 
>> webrev - http://cr.openjdk.java.net/~gromero/8201540/v2/
>> 
>> Thanks,
>> Bhaktavatsal Reddy
>> 
>> 
>> -----"core-libs-dev" <core-libs-dev-bounces at openjdk.java.net> wrote: 
>> -----
>> To: Alan Bateman <Alan.Bateman at oracle.com>
>> From: "Bhaktavatsal R Maram"
>> Sent by: "core-libs-dev"
>> Date: 04/16/2018 02:38PM
>> Cc: Tim Ellison <Tim_Ellison at uk.ibm.com>, 
>> ppc-aix-port-dev at openjdk.java.net, Java Core Libs 
>> <core-libs-dev at openjdk.java.net>
>> Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported 
>> charsets in java.base
>> 
>> Hi Alan,
>> 
>> I deleted IBM943C.java (using hg remove) and added new file 
>> IBM943C.java.template (using hg add). I now understand that using "hg 
>> rename" is giving more meaningful representation in webrev/index.html.
>> 
>> I will re-generate webrev by renaming source files to templates using 
>> "hg rename"
>> 
>> Thanks,
>> Bhaktavatsal Reddy
>> 
>> 
>> 
>> -----Alan Bateman <Alan.Bateman at oracle.com> wrote: -----
>> To: Bhaktavatsal R Maram <bhamaram at in.ibm.com>, Volker Simonis 
>> <volker.simonis at gmail.com>
>> From: Alan Bateman <Alan.Bateman at oracle.com>
>> Date: 04/16/2018 02:16PM
>> Cc: Java Core Libs <core-libs-dev at openjdk.java.net>, Tim Ellison 
>> <Tim_Ellison at uk.ibm.com>, ppc-aix-port-dev at openjdk.java.net
>> Subject: Re: RFR(S): 8201540: [AIX] Extend the set of supported 
>> charsets in java.base
>> 
>> 
>> On 16/04/2018 09:22, Bhaktavatsal R Maram wrote:
>>> 
>>> 3. Source files for IBM-942C and IBM-943C are changed to template to 
>>> support #1
>>> 
>> You might want to double check the webrev as it looks like you've 
>> added
>> templates where as I assume you mean to use "hg rename" to rename
>> IBM942C.java and IBM943C.java.
>> 
>> -Alan
>> 
>> 
>>